Trump’s chequered relationship with Scotland faces new test

President’s golf investments mask chilly relations with politicians and public